[Pidgin] #8846: people using web myspaceIM can't respond to pidgin myspaceIM

[Pidgin]

#8846: people using web myspaceIM can't respond to pidgin myspaceIM
----------------------------+-----------------------------------------------
 Reporter:  keeperofdakeys  |        Owner:  jeff   
     Type:  defect          |       Status:  closed 
Milestone:  2.6.0           |    Component:  MySpace
  Version:  2.5.5           |   Resolution:  fixed  
 Keywords:                  |  
----------------------------+-----------------------------------------------

Comment(by rekkanoryo at pidgin.im):

 (In [6aecd5e7eb4b4ced28c1c4c5e50386030abfe1bd]):[[BR]]
 In addition to the plucks listed below, I also changelogged these items.

 *** Plucked rev 7c614b09b72037ebd86c03fbbeac7794a155547b
 (darkrain42 at pidgin.im):
 disapproval of revision 'd34a15898cacf017df9190ca02741880be8dd940'

 xmlParseChunk is not reentrant. This /just happened/ to work for
 '<proceed/>' but not '<proceed></proceed>'. Closes #9271.

 *** Plucked rev 8806e5fba5cdb38ef9be6799e7e829dc2a762a69
 (markdoliner at pidgin.im):
 Stop exiting early from this function.  I don't believe it harms anything
 to continue executing even if body is null, and if we exit early then
 we don't call purple_connection_set_state(session->gc, PURPLE_CONNECTED)
 and the account never gets set to \"connected.\"  This seems to affect
 any MySpace account that has an empty buddy list.

 I'm pretty sure this used to work fine, so I'm assuming MySpace tweaked
 the data sent to the client when the user has an empty buddy list.

 *** Plucked rev 08979461f8fd9f122c665f3ee192c20788dd1bca
 (markdoliner at pidgin.im):
 Change the way we parse messages on MySpace a little bit.  This
 fixes #8846: people using web myspaceIM can't respond to pidgin myspaceIM

 For some reason IMs send using the myspace web site are sent so that
 they won't become offline messages if the other person is offline.
 I'm not really sure why that decision was made.

 So now we treat messages with bm 1 the same as messages with bm 121. This
 means
 we have to combine the function that parses out typing notification with
 the function that parses IMs. And we check for typing notifications by
 looking for %typing%. Which means if someone sends the IM \"%typing%\"
 with
 no markup then we'll interpret it as a typing notification. And there's
 nothing we can do to differentiate between the two. I asked.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8846#comment:2>
Pidgin <http://pidgin.im>
Pidgin