[Pidgin] #9525: error connecting to yahoo on compile pidgin 2.5.7

[Pidgin]

#9525: error connecting to yahoo on compile pidgin 2.5.7
------------------------+---------------------------------------------------
 Reporter:  jasonechoi  |        Owner:  sulabh.dev
     Type:  defect      |       Status:  pending   
Milestone:              |    Component:  Yahoo!    
  Version:  2.5.7       |   Resolution:            
 Keywords:              |  
------------------------+---------------------------------------------------
Changes (by darkrain42):

  * status:  new => pending


Comment:

 Well of course that's not going to work properly (for everyone else, diff
 at the bottom of this e-mail). You can't just comment out a variable
 assignment and change it so the variable is always ''0'' and expect it to
 work.

 The patch you want to apply to make it build properly is
 [e2bd07369c221038b091b908c8e07f0ae6179cd9].



 {{{
 $ diff -ur yahoo.c  your-yahoo.c
 --- yahoo.c     2009-06-26 09:48:17.000000000 -0700
 +++ your-yahoo.c        2009-06-26 09:47:33.000000000 -0700
 @@ -1469,7 +1469,9 @@
         }
         else if (len > 0 && ret_data && *ret_data) {
                 gchar **split_data = g_strsplit(ret_data, "\r\n", -1);
 -               int totalelements = g_strv_length(split_data);
 +               /*int totalelements = g_strv_length(split_data); */
 +               /* int response_no = -1; */
 +               int totalelements = 0;
                 int response_no = -1;
                 char *crumb = NULL;
                 char *crypt = NULL;
 @@ -1551,7 +1553,8 @@
         }
         else if (len > 0 && ret_data && *ret_data) {
                 gchar **split_data = g_strsplit(ret_data, "\r\n", -1);
 -               int totalelements = g_strv_length(split_data);
 +               /* int totalelements = g_strv_length(split_data); */
 +               int totalelements = 0;
                 int response_no = -1;
                 char *token = NULL;

 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9525#comment:6>
Pidgin <http://pidgin.im>
Pidgin