[Pidgin] #9525: error connecting to yahoo on compile pidgin 2.5.7

[Pidgin]

#9525: error connecting to yahoo on compile pidgin 2.5.7
------------------------+---------------------------------------------------
 Reporter:  jasonechoi  |        Owner:  sulabh.dev
     Type:  defect      |       Status:  pending   
Milestone:              |    Component:  Yahoo!    
  Version:  2.5.7       |   Resolution:            
 Keywords:              |  
------------------------+---------------------------------------------------
Changes (by darkrain42):

  * status:  new => pending


Comment:

 You have an extra `if (totalelements >= 5) {` and the two lines following
 it.

 {{{
 $ diff -ur yahoo.c  /home/paul/src/pidgin/yahoo.c
 --- yahoo.c     2009-06-26 09:48:17.000000000 -0700
 +++ /home/paul/src/pidgin/yahoo.c       2009-06-26 11:45:04.000000000
 -0700
 @@ -1469,11 +1469,24 @@
         }
         else if (len > 0 && ret_data && *ret_data) {
                 gchar **split_data = g_strsplit(ret_data, "\r\n", -1);
 -               int totalelements = g_strv_length(split_data);
 +               /* int totalelements = g_strv_length(split_data); */
 +               int totalelements = 0;
                 int response_no = -1;
                 char *crumb = NULL;
                 char *crypt = NULL;

 +
 +#if GLIB_CHECK_VERSION(2,6,0)
 +  totalelements = g_strv_length(split_data);
 +#else
 +  while (split_data[++totalelements] != NULL);
 +#endif
 +
 +
 +               if (totalelements >= 5) {
 +                       response_no = strtol(split_data[1], NULL, 10);
 +                       crumb = g_strdup(split_data[2] +
 strlen("crumb="));
 +
                 if (totalelements >= 5) {
                         response_no = strtol(split_data[1], NULL, 10);
                         crumb = g_strdup(split_data[2] +
 strlen("crumb="));

 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9525#comment:10>
Pidgin <http://pidgin.im>
Pidgin