[Pidgin] #8799: Small adjustment to previous fix in Message Notification Plugin

[Pidgin]

#8799: Small adjustment to previous fix in Message Notification Plugin
-------------------------+--------------------------------------------------
 Reporter:  Luigiwalser  |        Owner:  deryni      
     Type:  defect       |       Status:  new         
Milestone:               |    Component:  pidgin (gtk)
  Version:  2.5.5        |   Resolution:              
 Keywords:               |  
-------------------------+--------------------------------------------------

Comment(by Luigiwalser):

 OK, with focus prevention off, the raise option does what you'd expect.
 It raises only, it doesn't steal focus or unminimize.  The present option
 raises, steals focus, and unminimizes.  It should only unminimize.  In
 this case, I don't think the if block order matters.

 With focus prevention on, the unminimizing works (good), there's no focus
 stealing (good), but raising doesn't happen with either option (bad).

 The present option was added for unminimization in bug 2145, but I didn't
 complain about the focus stealing right away after it was added, because I
 didn't know the reason for it.  The way you describe the present option,
 it sounds like you're thinking about trying to work around the same
 metacity bug that caused Mandriva to add the stupid broken patch that
 caused bug 8780 to be filed.  So neither is solving that problem well, and
 I'm not sure either Pidgin or Mandriva (via a patch to Pidgin) should be
 trying to, but that's another argument :o).

 I tried changing handle_present to call pidgin_conv_window_show and that
 didn't work, it's just not unminimizing, which really blows my mind.  I
 don't understand why that won't work now.

 Let me know if you want anything else from me.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8799#comment:12>
Pidgin <http://pidgin.im>
Pidgin