[Pidgin] #8675: Changed Buddy State Notification to reflect Mobile status

Pidgin trac at pidgin.im
Sun Mar 15 04:03:54 EDT 2009


#8675: Changed Buddy State Notification to reflect Mobile status
---------------------------------------------+------------------------------
 Reporter:  jlintern                         |           Owner:         
     Type:  patch                            |          Status:  new    
Milestone:                                   |       Component:  plugins
  Version:  2.5.5                            |      Resolution:         
 Keywords:  buddy state notification mobile  |   Launchpad_bug:         
---------------------------------------------+------------------------------

Old description:

> References #3968
>
> Small change to the Buddy State Notification plugin to print messages
> when buddies go/return from mobile status.
>
> The only hitch--- I had to add a purple_signal_emit in prpl.c (which is
> duplicated in the subsequent call to purple_blist_update_buddy_status).
> It was the easiest way I could find for the correct behavior to surface
> in the plugin. As it stands, the signal emitted in prpl.c correctly
> handles the (available->mobile) case and the signal emitted in blist.c
> correctly handles the (mobile->available) case.
>
> AFAICT, the issue arises from the active/exclusive status paradigm and I
> don't understand the model well enough to do this the Right Way.
>
> That said, I've been using this patch for a while now and haven't noticed
> any wonky behavior.

New description:

 References #3968

 Small change to the Buddy State Notification plugin to print messages when
 buddies go/return from mobile status.

 The only hitch--- I had to add a purple_signal_emit in prpl.c (which is
 duplicated in the subsequent call to purple_blist_update_buddy_status). It
 was the easiest way I could find for the correct behavior to surface in
 the plugin. As it stands, the signal emitted in prpl.c correctly handles
 the (available->mobile) case and the signal emitted in blist.c correctly
 handles the (mobile->available) case.

 AFAICT, the issue arises from the active/exclusive status paradigm and I
 don't understand the model well enough to do this the Right Way.

--

Comment(by jlintern):

 Actually, some notifications that aren't mobile-related are being
 duplicated now, so this patch is no good. However, someone might be able
 to take a look and figure out a better way to accomplish what I was after?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8675#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list