[Pidgin] #8751: Better logging levels for some messages (from mailing list)

[Pidgin]

#8751: Better logging levels for some messages (from mailing list)
-----------------------------------------+----------------------------------
 Reporter:  darkrain42                   |           Owner:           
     Type:  patch                        |          Status:  new      
Milestone:  Patches Needing Improvement  |       Component:  libpurple
  Version:  2.5.5                        |      Resolution:           
 Keywords:                               |   Launchpad_bug:           
-----------------------------------------+----------------------------------
Changes (by rekkanoryo):

  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 This patch on its surface looks good to me.  I just have a couple notes to
 make it a bit better in my eyes:
   * Most of the certificate debugs should be errors instead of info or
 warnings.  The only two in the patch that should be warnings (in my
 opinion, anyway) are the "User rejected cert" and "X.509 Scheme not
 regeistered" messages.  Please change the rest of them in certificate.c to
 `purple_debug_error()`.
   * In pluginpref.c, we should use the convenience function
 `purple_debug_warning()` instead of calling `purple_debug()`.  This is, of
 course, minor, and shouldn't block accepting the patch.
   * In upnp.c, shouldn't it be an error if the code can't determine the
 local IP address?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8751#comment:2>
Pidgin <http://pidgin.im>
Pidgin