[Pidgin] #8663: [PATCH] Make account editor fit smaller screens

Pidgin trac at pidgin.im
Wed Mar 25 02:04:20 EDT 2009


#8663: [PATCH] Make account editor fit smaller screens
--------------------+-------------------------------------------------------
 Reporter:  mterry  |           Owner:              
     Type:  patch   |          Status:  new         
Milestone:          |       Component:  pidgin (gtk)
  Version:  2.5.5   |      Resolution:              
 Keywords:  size    |   Launchpad_bug:              
--------------------+-------------------------------------------------------

Old description:

> This is a sister bug to bug 7548.
>
> This patch will make the 'Add/Modify Account' dialog fit the smaller form
> factor of today's netbooks (~1280x576).
>
> The only problem protocol was SILC, whose many many options made the
> dialog too large vertically.
>
> To work around this, I did the following:
>
> * Move proxy settings to their own tab (as discussed on mailing list)
>
> * Took away the header labels for Proxy and Protocol options, because
> they were the only sections on their tabs
>
> * Tweaked the borders of a couple boxes.  Notably, I reduced the dialog's
> total border and the spacing between the content and dialog-button boxes.
> This involved a change from PIDGIN_HIG_BORDER to PIDGIN_HIG_BOX_SPACE.
> Now, this may seem like a break from HIG, but it actually makes the
> dialog *respect* the HIG. Before, I was getting ~20 pixel border, and the
> dialog buttons were swimming in space.  It seems GTK+ insists on adding
> some of its own spacing around the place.  By reducing the assigned
> border, it now is 12 pixels around the edge of the dialog, and about 20
> around the dialog buttons.  Those dialog buttons seem to insist on lots
> of space.  This same fix might want to be applied elsewhere?  The other
> dialogs in pidgin seem roomy to me.  Do I just have some crazy theme that
> is doing this (Human on Ubuntu)?

New description:

 This is a sister bug to bug #7548.

 This patch will make the 'Add/Modify Account' dialog fit the smaller form
 factor of today's netbooks (~1280x576).

 The only problem protocol was SILC, whose many many options made the
 dialog too large vertically.

 To work around this, I did the following:

  * Move proxy settings to their own tab (as discussed on mailing list)
  * Took away the header labels for Proxy and Protocol options, because
 they were the only sections on their tabs
  * Tweaked the borders of a couple boxes.  Notably, I reduced the dialog's
 total border and the spacing between the content and dialog-button boxes.
 This involved a change from `PIDGIN_HIG_BORDER` to `PIDGIN_HIG_BOX_SPACE`.
 Now, this may seem like a break from HIG, but it actually makes the dialog
 '''respect''' the HIG. Before, I was getting ~20 pixel border, and the
 dialog buttons were swimming in space.  It seems GTK+ insists on adding
 some of its own spacing around the place.  By reducing the assigned
 border, it now is 12 pixels around the edge of the dialog, and about 20
 around the dialog buttons.  Those dialog buttons seem to insist on lots of
 space.  This same fix might want to be applied elsewhere?  The other
 dialogs in pidgin seem roomy to me.  Do I just have some crazy theme that
 is doing this (Human on Ubuntu)?

--

Comment(by rekkanoryo):

 Fixed some wiki formatting on the original submission.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8663#comment:2>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list