[Pidgin] #8799: Small adjustment to previous fix in Message Notification Plugin

Pidgin trac at pidgin.im
Thu Mar 26 15:33:17 EDT 2009


#8799: Small adjustment to previous fix in Message Notification Plugin
--------------------------+-------------------------------------------------
 Reporter:  Luigiwalser   |           Owner:  lschiere
     Type:  defect        |          Status:  new     
Component:  unclassified  |         Version:  2.5.5   
 Keywords:                |   Launchpad_bug:          
--------------------------+-------------------------------------------------
 This is an addendum to Bug 2145, which I would have reopened, but I see no
 way to do that.  http://developer.pidgin.im/ticket/2145

 The patch I had posted there worked perfectly.  The patch that was
 accepted (also attached there) caused me a problem that I had to turn
 focus stealing prevention all the way up on my window manager to resolve,
 and even that wasn't a perfect resolution.

 I didn't occur to me why the accepted patch was behaving differently until
 now.  My patch had it show/present then raise, the accepted patch is in
 the other order.

 Could you please switch the order of these two if blocks in notify.c to
 fix it?  Thank you.

 if (purple_prefs_get_bool("/plugins/gtk/X11/notify/method_raise"))
   handle_raise(purplewin);
 if (purple_prefs_get_bool("/plugins/gtk/X11/notify/method_present"))
   handle_present(conv);

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8799>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list