[Pidgin] #9120: Crash when changing buddy icon with mystatusbox enabled

[Pidgin]

#9120: Crash when changing buddy icon with mystatusbox enabled
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |        Owner:  darkrain42
     Type:  defect      |       Status:  closed    
Milestone:  2.6.0       |    Component:  libpurple 
  Version:  2.5.5       |   Resolution:  fixed     
 Keywords:  statusbox   |  
------------------------+---------------------------------------------------

Comment(by darkrain42 at pidgin.im):

 (In [b61d4041b364e1dc67590000472f86f9c92717d3]):[[BR]]
 Fix the crash/leaks in statusbox

 *** Plucked rev 0cb6e54b (darkrain42 at pidgin.im):
 Look up the old image before we store the new one in the hash table.

 Looking up the new image and then unref:ing it (hence freeing the data
 and subsequently returning it) is not good. This was causing problems
 with changing buddy icons while using mystatusbox. Refs #9120.

 *** Plucked rev d25c9ed7 (darkrain42 at pidgin.im):
 Don't leak image refs in gtkstatusbox and assertion failure in nullprpl

 purple_imgstore_new_from_file gives us a ref and
 pidgin_status_box_set_buddy_icon also takes a ref.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9120#comment:3>
Pidgin <http://pidgin.im>
Pidgin