[Pidgin] #9234: XMPP Pings must be made configurable for users

Pidgin trac at pidgin.im
Mon May 25 04:14:45 EDT 2009


#9234: XMPP Pings must be made configurable for users
-------------------------+--------------------------------------------------
 Reporter:  niraj19july  |        Owner:  deryni 
     Type:  defect       |       Status:  pending
Milestone:               |    Component:  XMPP   
  Version:  2.5.6        |   Resolution:         
 Keywords:               |  
-------------------------+--------------------------------------------------
Changes (by niraj19july):

  * status:  pending => new


Comment:

 In version 2.4, timeout was 30 sec. In pidgin 2.5.1 onwards timeout is 120
 seconds. How did you decide that timeout of 2 minutes is okay? What i am
 saying is let the end user decide all these timeout values. It is up to
 the end user whether he wants to choose 2 minutes or 3 minutes. You just
 need to put the default value for the timeout.
 Further, i think providing a configuration knob to disable these pings is
 also a good idea. By default, pings can be enabled but if the end user
 wants to disable it then he should be able to do so. If an end user
 disables the pings, he has done it purposefully and there is nothing wrong
 in it.
 In my opininon, timeouts for TCP connection are not needed as they are
 pretty fast.
 As far as file transfer is concerned, it is mostly handled at the client
 side. Server just provides the initial handshake and file is retrieved
 using OOB mechanism. For IBB, which is not supported by Pidgin as of now,
 chunks of base64 encoded data is sent between the users and i don't think
 there is any need of timeout for this case too. Further, operations like
 file transfer can't be considered as a critical operation. This is because
 if a file transfer is slow, it is fine as long as connection to the server
 is not lost.
 If you still want to provide the timeouts for TCP connection and file
 transfer, it is up to you. It is fine as long as you make them
 configurable for the end user.

 PS: Disconnection from a slow server triggers re-login storm on ANY server
 for most of the cases. These login storms will further contribute to the
 slowness of the server.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9234#comment:2>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list