[Pidgin] #7457: Double UTF-8 encoding in oscar protocol

Pidgin trac at pidgin.im
Wed Nov 4 00:33:42 EST 2009


#7457: Double UTF-8 encoding in oscar protocol
-----------------------------------------+----------------------------------
 Reporter:  xmarchello                   |        Owner:  MarkDoliner
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  ICQ        
  Version:  2.5.2                        |   Resolution:             
 Keywords:  oscar icq                    |  
-----------------------------------------+----------------------------------
Changes (by darkrain42):

  * keywords:  oscar icq patch => oscar icq
  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 Replying to [comment:3 nops]:
 > The real problem in oscar.c in function purple_ssi_authrequest.
 Authorization request comes in UTF-8, but in this function it's convert to
 UTF-8 (msg -> reason). This is wrong, and this not need to be converted.
 > Also, libpurple send authorization request in UTF-8 (family_feedbag.c
 function aim_ssi_sendauth).
 >
 > Why it need to be converted? I think this is a mistake.

 This is my conclusion too. However, lacking a history of experience with
 OSCAR (and in particular all the various ICQ clients), I'm not comfortable
 saying that the solution is just to remove the decoding step (or have the
 default be Unicode and then also try the value from the account options).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7457#comment:6>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list