[Pidgin] #10605: libpurple chat API documentation

Pidgin trac at pidgin.im
Sat Nov 7 14:56:56 EST 2009


#10605: libpurple chat API documentation
--------------------------------+-------------------------------------------
 Reporter:  StTwister           |        Owner:           
     Type:  patch               |       Status:  new      
Milestone:                      |    Component:  libpurple
  Version:  2.6.3               |   Resolution:           
 Keywords:  chat documentation  |  
--------------------------------+-------------------------------------------

Comment(by darkrain42):

 This looks great to me.

 Possible changes:
  * I would clarify that chat_info_defaults and get_chat_name function as
 opposites.  I mistakenly interpreted it as get_chat_name somehow creating
 the opposite of "g_hash_table_new_full(g_str_hash, g_str_equal, NULL,
 g_free)" (which I'll admit made no sense to me).
  * You could also use "@returns", although that's just a minor nitpick.
  * Lastly, what's the return value of chat_send?

 You can go ahead and commit this to im.pidgin.pidgin as far as I'm
 concerned.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10605#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list