[Pidgin] #9322: Search friend by email address

Pidgin trac at pidgin.im
Sat Oct 3 23:04:27 EDT 2009


#9322: Search friend by email address
-----------------------------------------+----------------------------------
 Reporter:  LCamel                       |        Owner:              
     Type:  patch                        |       Status:  new         
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.5.5                        |   Resolution:              
 Keywords:  search                       |  
-----------------------------------------+----------------------------------
Changes (by rekkanoryo):

  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 This patch introduces braces where not necessary and touches the internals
 of !PurpleBuddy and GValue.  Instead of touching members directly, use
 get/set functions.  Also, you should use PURPLE_CONTACT() instead of
 casting to a !PurpleContact*.  Additionally, you can't blindly cast a
 pointer to an int as you do to get NODE_COLUMN.  Pointers are not the same
 size as ints on all platforms.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9322#comment:3>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list