[Pidgin] #10523: Bad order of define(s) for _FILE_OFFSET_BITS for Solaris8 --

[Pidgin]

#10523: Bad order of define(s) for _FILE_OFFSET_BITS for Solaris8 --
------------------------------------------------------+---------------------
 Reporter:  aab at purdue.edu                            |     Owner:  rekkanoryo
     Type:  defect                                    |    Status:  new       
Component:  unclassified                              |   Version:  2.6.2     
 Keywords:  _FILE_OFFSET_BITS include order Solaris8  |  
------------------------------------------------------+---------------------
 A number of the *.c files have a misorder of includes that causes a
 "#define _FILE_OFFSET_BITS 32" directive to precede the "#define
 _FILE_OFFSET_BITS 64" directive.

 #include <stdio.h>
   does a #include <sys/feature_tests.h>
     which does the 32-bit define if _FILE_OFFSET_BITS isn't defined
 #include "internal.h"
   does a #include "config.h"
     which does the unconditional 64-bit define

 The Sun Studio 11 C compiler complains about the value change.  My quick
 and dirty workaround was to add "-D_FILE_OFFSET_BITS=64" to CPPFLAGS.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10523>
Pidgin <http://pidgin.im>
Pidgin