[Pidgin] #10481: Segfault on 'contact list send' in sim-im

[Pidgin]

#10481: Segfault on 'contact list send' in sim-im
--------------------------+-------------------------------------------------
 Reporter:  nightwing666  |        Owner:  MarkDoliner
     Type:  defect        |       Status:  closed     
Milestone:                |    Component:  ICQ        
  Version:  2.6.2         |   Resolution:  fixed      
 Keywords:                |  
--------------------------+-------------------------------------------------
Changes (by markdoliner at pidgin.im):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [c8d72361e5c9828c476ac5cb94f17584b1f407f9]):[[BR]]
 *** Plucked rev 781682333aea0c801d280c3507ee25552a60bfc0
 (markdoliner at pidgin.im):
 Fix a remote-crash bug in ICQ (and probably AIM).  It happens when the
 SIM IM client tries to send us contacts.

 Fixes #10481

 *** Plucked rev b988b4d536524e124366b7da01b0e8706ac0a099
 (markdoliner at pidgin.im):
 Don't call aim_src_clientready() until we have activated our feedbag
 (and also until after we have our bos rights, but I'm not sure if that
 matters).  This fixes the bug where AIM block lists recently stopped
 working.  I imagine AIM permit lists were also broken, as well as the
 three ICQ privacy lists.

 It's conceivable that this will also fix the bug where your contact
 list is sometimes empty, but I have no evidence to support that either
 way.

 This change will be in the next release of Pidgin, 2.6.3, which will
 probably be released within the next week.

 Thanks to AOL for telling me what we were doing wrong.

 Fixes #10489
 Fixes #10499
 Fixes #10509
 Refs #10411

 *** Plucked rev e5cd28dabffaedf15ae16dd9dfb64e2c0fe40e8c
 (darkrain42 at pidgin.im):
 printf(\"%s\", NULL) when a cert has no CN. Refs #10519.

 This is a temporary change to keep it from crashing while not introducing
 a string change.

 *** Plucked rev a98871332460101c6e9638650081c8badad3066b
 (darkrain42 at pidgin.im):
 Print that specific message only when there is a CN; otherwise fall back
 to the error from invalidity_reason_to_string().  Fixes #10519.

 Thanks for pointing this out, QuLogic.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10481#comment:1>
Pidgin <http://pidgin.im>
Pidgin