[Pidgin] #8155: MSN offline messages (still) crash crash crash

[Pidgin]

#8155: MSN offline messages (still) crash crash crash
------------------------------------+---------------------------------------
 Reporter:  windx86                 |        Owner:  khc
     Type:  defect                  |       Status:  new
Milestone:                          |    Component:  MSN
  Version:  2.5.8                   |   Resolution:     
 Keywords:  offline messages crash  |  
------------------------------------+---------------------------------------

Comment(by sadrul):

 I experienced this crash (or so it seems) today, with the following
 backtrace:
 {{{
 #0  0xb6e84dc3 in msn_oim_request_cb (request=0xa3386a8,
 response=0xb7b5f7dc, req_data=0xbfc94d38) at
 /devel/pidgin/libpurple/protocols/msn/oim.c:200
 #1  0xb7e418e6 in g_timeout_dispatch (source=0xa207aa8, callback=0,
 user_data=0xa3386a8) at /tmp/buildd/glib2.0-2.16.6/glib/gmain.c:3446
 #2  0xb7e411b8 in IA__g_main_context_dispatch (context=0x808a430) at
 /tmp/buildd/glib2.0-2.16.6/glib/gmain.c:2012
 #3  0xb7e44853 in g_main_context_iterate (context=0x808a430, block=1,
 dispatch=1, self=0x8083008) at
 /tmp/buildd/glib2.0-2.16.6/glib/gmain.c:2645
 #4  0xb7e44d72 in IA__g_main_loop_run (loop=0x8254b18) at
 /tmp/buildd/glib2.0-2.16.6/glib/gmain.c:2853
 #5  0xb7ca60bd in gnt_main () at /devel/pidgin/finch/libgnt/gntmain.c:532
 #6  0x0806b308 in main (argc=3, argv=0xbfc94f24) at
 /devel/pidgin/finch/finch.c:439
 }}}

 I believe this will fix it: http://pidgin.im/~sadrul/pp/8155_fix.txt

 From what I can see, the reason for the crash is that since the callback
 function (msn_oim_request_helper, set in oim.c:msn_oim_request_cb) is
 declared void, the timeout-callback may not get removed, in which case it
 will continue to be called continuously. So the fix is to use a wrapper
 callback that will call the callback and return FALSE so the timeout-
 callback gets removed.

 Sounds good?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8155#comment:26>
Pidgin <http://pidgin.im>
Pidgin