[Pidgin] #10897: "View Log" (History) does not support Conference Chats (Multi-user chats)

Pidgin trac at pidgin.im
Fri Apr 16 12:03:43 EDT 2010


#10897: "View Log" (History) does not support Conference Chats (Multi-user chats)
------------------------------------+---------------------------------------
 Reporter:  dk016926                |        Owner:  sadrul      
     Type:  patch                   |       Status:  new         
Milestone:  Patches Needing Review  |    Component:  pidgin (gtk)
  Version:  2.5.5                   |   Resolution:              
 Keywords:  Conference History Log  |  
------------------------------------+---------------------------------------

Comment(by sadrul):

 We cannot really use the current 'View User Log' menu and the structs
 because we expose !PidginBuddyCompletionEntry and
 !PidginFilterBuddyCompletionEntryFunc to plugins, and we would need to
 break existing plugins that are using these if we wanted to accommodate
 chats in the same structure.

 Instead, I think we should have a separate 'View Chat Log' menu item to
 popup a dialog where only chat names will be included in the suggestion
 list. We can start with no filtering for the moment (which you are doing
 in the patch), and perhaps add it later.

 Some notes on the patch:
  * 'normname' should be freed when '!is_found'. (gtkdialogs.c)
  * 'chat_name' should be freed. (gtkdialogs.c, gtkutils.c)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10897#comment:2>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list