[Pidgin] #12431: Patch for MSN crash caused by msn_switchboard_request

[Pidgin]

#12431: Patch for MSN crash caused by msn_switchboard_request
--------------------------+-------------------------------------------------
 Reporter:  hanzz         |     Owner:  rekkanoryo
     Type:  patch         |    Status:  new       
Component:  unclassified  |   Version:  2.7.2     
 Keywords:                |  
--------------------------+-------------------------------------------------
 Attached crash and log describes the problem:


 {{{
 MsnSwitchBoard *
 msn_session_get_swboard(MsnSession *session, const char *username,
                                                 MsnSBFlag flag)
 {
 ....
                 swboard = msn_switchboard_new(session);
                 swboard->im_user = g_strdup(username);
                 msn_switchboard_request_add_user(swboard, username);
 ....
         return swboard;
 }
 }}}


 1. New switchboard is created

 2. msn_switchboard_request(swboard); is called, but during this call there
 is problem with connection to MSN network and account is disconnected
 (switchboard is freed and no longer exists after that function)

 3. non-existing swboard is used => crash

 This is more global problem in prpl-msn implementation and my patch fixes
 just one occurrence, but I would say we can start with my change.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12431>
Pidgin <http://pidgin.im>
Pidgin