[Pidgin] #12473: Code duplicaton: Create each theme combo using a call to a common function

Pidgin trac at pidgin.im
Wed Aug 11 05:10:14 EDT 2010


#12473: Code duplicaton: Create each theme combo using a call to a common function
--------------------+-------------------------------------------------------
Reporter:  nix_nix  |        Type:  patch       
  Status:  new      |   Component:  pidgin (gtk)
 Version:  2.7.2    |    Keywords:              
--------------------+-------------------------------------------------------
 There's some copy-and-paste code in gtkprefs.c:theme_page responsible for
 the creation of the for theme combo boxes.

 I've replaced the four paragraphs with four calls to a new function which
 create and add the GtkHBox containing the combo and the label to the
 pidgin frame.

 This reduces code duplication and gives me one place to rearrange the
 layout so that it's not quite as wide, thus fitting better on a screen
 that's only 800 pixels wide.

 The patch is also available from branch org.maemo.garage.pidgin.pidgin
 .gtkprefs-theme-combo-code-duplication from piiickoska.go-nix.ca (when the
 monotone server is not b0rked :-S)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12473>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list