[Pidgin] #11863: Using "Get X-Status Msg" on offline ICQ buddy causes Pidgin's crash

[Pidgin]

#11863: Using "Get X-Status Msg" on offline ICQ buddy causes Pidgin's crash
--------------------------------------+-------------------------------------
 Reporter:  Fellrond                  |        Owner:  MarkDoliner
     Type:  defect                    |       Status:  closed     
Milestone:  2.7.1                     |    Component:  ICQ        
  Version:  2.7.0                     |   Resolution:  fixed      
 Keywords:  x-status oscar icq 2.7.0  |  
--------------------------------------+-------------------------------------

Comment(by rekkanoryo at pidgin.im):

 (In [dd496d006f7414efd30774f23f17af433cd38a0e]):[[BR]]
 *** Plucked rev cfe0e649dda34d9252d40d8f67e445336a247998
 (darkrain42 at pidgin.im):
 yahoo: Fix a few race-condition crashes at login

 (if the account disconnects while these fetches are in-progress).

 *** Plucked rev 1724c0c7cbf56b08b5454e796b80173ec9aef481
 (rekkanoryo at pidgin.im):
 Very hackily implement a fallback mechanism in Yahoo, but not for Yahoo
 Japan
 because we don't know hosts we can fall back to there yet.  This fallback
 mechanism just blindly connects to scsa.msg.yahoo.com if the HTTP-based CS
 lookup fails.  I guarantee this will break in the future.  Refs #11986.

 *** Plucked rev 06fcbcb8d044bcd6887415dc87274071bb724596
 (rekkanoryo at pidgin.im):
 Change the function of the "proxy_ssl" account option to cover regular
 HTTP
 requests as well as HTTPS requests.  While this does fix the core issue of
 #11986, there is still more that I need to do to fix his issue.  Refs
 #11986.

 *** Plucked rev f08e4f567582f7d28683d043f759a720ee9142e3
 (rekkanoryo at pidgin.im):
 Make HTTP proxy detection in the yahoo prpls a bit more robust.  This
 should
 solve some weird proxy related items I couldn't figure out before.  Refs
 #11986.

 *** Plucked rev baeaaf7de69d9f99b7545dda73f219292c4dd106
 (datallah at pidgin.im):
 Attempt to improve handling of HTTP requests on port 80 when there is a
 HTTP
 proxy that requires authentication involved.
 This also has a fix to make sure that we continue to use the same proxy
 when
 we are redirected to an alternative URL.
 I'm tempted to create a purple_proxy_append_proxy_auth_headers(), but that
 would have to wait until 2.8.0.
 Refs #11986.
 Refs #11908.

 *** Plucked rev 52fb5cb4cd8795906a7313dd5edde763a4848a3e
 (qulogic at pidgin.im):
 Normalize the remote passport before sending a P2P message. If it's not
 lowercase, then the switchboard will reject it, causing a whole lot of
 extra network traffic as Pidgin attempts to resend the same (incorrect)
 message.

 Fixes #11532.

 *** Plucked rev e3dd36706068f3b8eabd630ff71d270c145cce42
 (markdoliner at pidgin.im):
 If we get an error SNAC on the ICBM family and it's missing buddy name
 then
 don't fallthrough to the default error handler in misc.c.  This was
 causing
 purple_parse_msgerr() in oscar.c to get called with different va_args than
 it was expecting, which caused a crash.  Specifically when trying to fetch
 the ICQ x-status of an offline buddy.

 Fixes #11863.  This is nosnilmot's patch, I believe.  I had no part in it,
 other than verifying that I do believe it'll fix the crash.


 The above revision plucks authorized by Zac West and Robert Vehse.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11863#comment:34>
Pidgin <http://pidgin.im>
Pidgin