Re: [Pidgin] #12317: [PATCH] history.с plugin, new features

Pidgin trac at pidgin.im
Mon Aug 23 00:49:03 EDT 2010


#12317: [PATCH] history.с plugin, new features
------------------------------------+---------------------------------------
 Reporter:  orm                     |        Owner:         
     Type:  patch                   |       Status:  new    
Milestone:  Patches Needing Review  |    Component:  plugins
  Version:                          |   Resolution:         
 Keywords:  history                 |  
------------------------------------+---------------------------------------

Comment(by QuLogic):

 The code around line 130 is quite inefficient. Reverse the list, find the
 last element, then walk backwards? Why not just walk the list forwards?
 Additionally, showing multiple logs is already implemented by the
 [http://plugins.guifications.org/trac/wiki/enhancedhist Enhanced History
 plugin].

 I'm not really sure it's really necessary to have an option for every
 single type of formatting possible either.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12317#comment:7>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list