[Pidgin] #12519: Patch for "pounce when my status is..."
Pidgin
trac at pidgin.im
Tue Aug 24 14:40:36 EDT 2010
#12519: Patch for "pounce when my status is..."
--------------------------------------------+-------------------------------
Reporter: grigoryj | Owner: rekkanoryo
Type: patch | Status: new
Milestone: Patches Needing Review | Component: unclassified
Version: 2.7.3 | Resolution:
Keywords: pidgin libpurple pounce status |
--------------------------------------------+-------------------------------
Comment(by salinasv):
This patches add API so it can't be applied until a minor version release.
I'm not really familiar with status code so this needs a review form
someone else but I will point you some things on your patch.
* Avoid adding newlines, pounce.c:456, gtkpounce.c:1625
* Don't use // comments, pounce.c:1005
* Fix the space to be consistent with the enum, pounce.h
Other than that, it looks ok to me. I haven't tested or anything just read
it. =P
--
Ticket URL: <http://developer.pidgin.im/ticket/12519#comment:2>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list