[Pidgin] #12519: Patch for "pounce when my status is..."

[Pidgin]

#12519: Patch for "pounce when my status is..."
--------------------------------------------+-------------------------------
 Reporter:  grigoryj                        |        Owner:  darkrain42
     Type:  patch                           |       Status:  new       
Milestone:  Patches Needing Improvement     |    Component:  libpurple 
  Version:  2.7.3                           |   Resolution:            
 Keywords:  pidgin libpurple pounce status  |  
--------------------------------------------+-------------------------------

Comment(by grigoryj):

 Hello,
 I fixed the issues:

  * comment/newline issues
  * using the name of status instead of integral value
  * changed the name of create_status_types_menu to
 pidgin_create_status_types_menu

 Concerning the other issues:
  * gtk_combo_box_get_active(GTK_COMBO_BOX(dialog->status)) +
 (PURPLE_STATUS_UNSET+1) - as you noticed a similar way is used in
 gtksavedstatuses.c, so I think this is good enough
  * About generic fields: currently my code generates the following XML:
  {{{
  <fields>
   <field name='status' value='away'/>
  </fields>
  }}}
  Isn't this generic enough?

  * About multiple pounce statuses: probably a good idea, but I'm not too
 comfortable writing GUI code. If anyone wishes to do the GUI part of this,
 I'll make necessary amendments to the libpurple part as quickly as
 possible.

 I'm attaching the improved version of the patch. Thank you all very much
 for taking time to look at the code.

 Cheers,
 Grigory

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12519#comment:6>
Pidgin <http://pidgin.im>
Pidgin