[Pidgin] #11560: Pidgin crashes when reconnecting to Facebook XMPP after idle period

[Pidgin]

#11560: Pidgin crashes when reconnecting to Facebook XMPP after idle period
-----------------------------------+----------------------------------------
 Reporter:  jmccabe                |        Owner:  darkrain42     
     Type:  defect                 |       Status:  closed         
Milestone:  2.7.4                  |    Component:  winpidgin (gtk)
  Version:  2.6.6                  |   Resolution:  fixed          
 Keywords:  crash xmpp digest md5  |  
-----------------------------------+----------------------------------------
Changes (by darkrain42 at pidgin.im):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 2.7.4


Comment:

 (In [1fa9e4afdd810001996bc2b829fd6027f21a882f]):[[BR]]
 jabber: Fix a pernicious race condition in our cyrus auth code

 About sasl_getsecret_t, sasl.h reads, in part:
  outputs:
   psecret set to password structure which must persist until
           next call to getsecret **in same connection**, but middleware
           will erase password data when it's done with it.

 Clearly this needs to be per-JabberStream*, not a static var.
 Jan Kaluza noted the static var and then I noted the sasl.h docs.
 Fixes #11560

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11560#comment:29>
Pidgin <http://pidgin.im>
Pidgin