[Pidgin] #12981: Allow to set SDES properties of RTP conference

Pidgin trac at pidgin.im
Tue Dec 7 18:07:07 EST 2010


#12981: Allow to set SDES properties of RTP conference
------------------------------------+---------------------------------------
 Reporter:  haakon                  |        Owner:  Maiku          
     Type:  enhancement             |       Status:  new            
Milestone:  Patches Needing Review  |    Component:  Voice and Video
  Version:                          |   Resolution:                 
 Keywords:  RTP SDES RFC1889        |  
------------------------------------+---------------------------------------

Comment(by haakon):

 Replying to [comment:2 darkrain42]:
 > Why choose to terminate with a parameter whose 'name' field is NULL?  Is
 that a standard idiom for GParameters?

 No, this is not any standard usage. Later I looked through some code that
 uses GParameter, seems most ofter the size of an array is passed along in
 a separate variable and there is no termination. Because
 purple_media_add_stream() already uses this approach, I updated
 purple_media_set_params() to get additional num_params argument.

 > It would be good if the API had a way to determine if the current
 backend /supports/ these properties (or better yet, query what properties
 it supports)

 I added APIs allowing both - getting list of all supported properties and
 querying whether particular property is recognized.

 > I'm also a little concerned about this turning into "Pass random blobs
 through the !PurpleMedia interface", but this seems relatively sane so
 far.

 Of course this should be used with reason. My intention is to only use
 this to configure complementary parameters that do not radically affect
 the media streaming and which are supported only by some (future)
 backends, where adding a new get/set functions to the API for each of them
 can be overkill. Media streams and codecs in libpurple already have this
 possibility.

 Attaching updated patch file...

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12981#comment:3>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list