[Pidgin] #12507: [PATCH] Build warnings / portability issues x86_64

[Pidgin]

#12507: [PATCH] Build warnings / portability issues x86_64
------------------------------------+---------------------------------------
 Reporter:  dimstar                 |        Owner:  rekkanoryo  
     Type:  patch                   |       Status:  new         
Milestone:  Patches Needing Review  |    Component:  unclassified
  Version:  2.7.7                   |   Resolution:              
 Keywords:                          |  
------------------------------------+---------------------------------------
Description changed by darkrain42:

Old description:

> Building pidgin, up to 2.7.3, results in those warnings: file included
> from dbus-server.c:426:0:
> dbus-bindings.c: In function 'purple_conversation_set_data_DBUS':
> dbus-bindings.c:4209:2: warning: passing argument 3 of
> 'purple_conversation_set_data' makes pointer from integer without a cast
> conversation.h:576:6: note: expected 'gpointer' but argument is of type
> 'dbus_int32_t'
> dbus-bindings.c: In function 'purple_conversation_get_data_DBUS':
> dbus-bindings.c:4226:9: warning: assignment makes integer from pointer
> without a cast
> dbus-bindings.c: In function 'purple_core_quit_cb_DBUS':
> dbus-bindings.c:5488:2: warning: passing argument 1 of
> 'purple_core_quit_cb' makes pointer from integer without a cast
> core.h:120:10: note: expected 'gpointer' but argument is of type
> 'dbus_int32_t'
> dbus-bindings.c: In function 'purple_prefs_set_generic_DBUS':
> dbus-bindings.c:7380:2: warning: passing argument 2 of
> 'purple_prefs_set_generic' makes pointer from integer without a cast
> prefs.h:198:6: note: expected 'gpointer' but argument is of type
> 'dbus_int32_t'
> dbus-bindings.c: In function 'purple_util_format_song_info_DBUS':
> dbus-bindings.c:10554:2: warning: passing argument 4 of
> 'purple_util_format_song_info' makes pointer from integer without a cast
> media/../util.h:120:8: note: expected 'gpointer' but argument is of type
> 'dbus_int32_t'
>
> which in the openSUSE build root policy checks are raised to errors:
> E: pidgin 64bit-portability-issue dbus-bindings.c:4209, 5488, 7380, 10554
>
> The attached patch removes gpointer from the list of simple types, which
> resolves the issue (the patch has been in openSUSE packages for a long
> time already, since March 2008.
>
> Please merge the patch in upstream code, so we can drop it in our
> packages.

New description:

 Building pidgin, up to 2.7.3, results in those warnings:

 {{{
 file included from dbus-server.c:426:0:
 dbus-bindings.c: In function 'purple_conversation_set_data_DBUS':
 dbus-bindings.c:4209:2: warning: passing argument 3 of
 'purple_conversation_set_data' makes pointer from integer without a cast
 conversation.h:576:6: note: expected 'gpointer' but argument is of type
 'dbus_int32_t'
 dbus-bindings.c: In function 'purple_conversation_get_data_DBUS':
 dbus-bindings.c:4226:9: warning: assignment makes integer from pointer
 without a cast
 dbus-bindings.c: In function 'purple_core_quit_cb_DBUS':
 dbus-bindings.c:5488:2: warning: passing argument 1 of
 'purple_core_quit_cb' makes pointer from integer without a cast
 core.h:120:10: note: expected 'gpointer' but argument is of type
 'dbus_int32_t'
 dbus-bindings.c: In function 'purple_prefs_set_generic_DBUS':
 dbus-bindings.c:7380:2: warning: passing argument 2 of
 'purple_prefs_set_generic' makes pointer from integer without a cast
 prefs.h:198:6: note: expected 'gpointer' but argument is of type
 'dbus_int32_t'
 dbus-bindings.c: In function 'purple_util_format_song_info_DBUS':
 dbus-bindings.c:10554:2: warning: passing argument 4 of
 'purple_util_format_song_info' makes pointer from integer without a cast
 media/../util.h:120:8: note: expected 'gpointer' but argument is of type
 'dbus_int32_t'
 }}}

 which in the openSUSE build root policy checks are raised to errors: E:
 pidgin 64bit-portability-issue dbus-bindings.c:4209, 5488, 7380, 10554

 The attached patch removes gpointer from the list of simple types, which
 resolves the issue (the patch has been in openSUSE packages for a long
 time already, since March 2008.

 Please merge the patch in upstream code, so we can drop it in our
 packages.

--

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12507#comment:5>
Pidgin <http://pidgin.im>
Pidgin