[Pidgin] #10538: Automaticaly wrap menu in buddy list window
Pidgin
trac at pidgin.im
Thu Dec 30 23:03:14 EST 2010
#10538: Automaticaly wrap menu in buddy list window
------------------------------------+---------------------------------------
Reporter: Vadim_Druzhin | Owner: deryni
Type: patch | Status: new
Milestone: Patches Needing Review | Component: pidgin (gtk)
Version: 2.6.3 | Resolution:
Keywords: menu buddy list |
------------------------------------+---------------------------------------
Comment(by deryni):
(I swear I commented on this at the time, though apparently not here, and
my answer at this point is different than it was then.)
We've rejected this in the past on the principal that it is something that
GTK+ should really be handling for us and not something we should be doing
ourselves.
That being said, I'm less opposed to this now than I was previously.
As written the patch looks fairly good (though there are some stylistic
things that would want touching up, including moving menu_extra to the
private struct). I can't comment on the GTK+ size calculation bits
directly as I'm not familiar with the sizing/allocation mechanism involved
at the moment but the rest of it looks pretty good.
We would need to make sure it works correctly when menu-tray icons are
present but it looks like it has code to handle that case.
I do wonder if it might make more sense to look into writing our own
version of the menu widget instead of hacking this in this way.
--
Ticket URL: <http://developer.pidgin.im/ticket/10538#comment:3>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list