[Pidgin] #11339: Custom Protocol Icons

Pidgin trac at pidgin.im
Sat Feb 13 10:22:03 EST 2010

#11339: Custom Protocol Icons
 Reporter:  Universe_JDJ    |        Owner:  rekkanoryo  
     Type:  rejected_patch  |       Status:  new         
Milestone:                  |    Component:  unclassified
  Version:  2.6.5           |   Resolution:              
 Keywords:                  |  
Changes (by rekkanoryo):

  * type:  plugin request => rejected_patch


 We will not accept a patch such as this.  String matching the domain
 portion of a JID is unacceptable and will be wrong in some cases--the
 protocol icons as they are now are based on the protocol plugin the
 buddies are provided with, which necessarily ties them to the protocol of
 the account they're provided with.  Using a string match such as this will
 make Google Talk buddies appear with a Google Talk protocol icon even when
 those buddies are in the roster of a non-Google Talk XMPP account.  That
 in itself isn't so bad, but what makes it worse, in my opinion, is that it
 will necessarily miss Google Apps for Your Domain users who have Google
 Talk enabled with their own domains.

Ticket URL: <http://developer.pidgin.im/ticket/11339#comment:10>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list