[Pidgin] #4598: Plus! color tags

Pidgin trac at pidgin.im
Sun Feb 14 21:16:10 EST 2010


#4598: Plus! color tags
---------------------------------+------------------------------------------
 Reporter:  daniele_athome       |        Owner:  salinasv    
     Type:  patch                |       Status:  new         
Milestone:  2.7.0                |    Component:  pidgin (gtk)
  Version:  2.3.1                |   Resolution:              
 Keywords:  pidgin blist markup  |  
---------------------------------+------------------------------------------

Comment(by sadrul):

 It should be using `purple_marshal_POINTER__POINTER`

 There's no reason to debug-print the name returned from a plugin as a
 warning. (We probably don't need to print anything in the debug window at
 all)

 Also, `ret` and the extra strdup is not necessary:
 {{{
         /* Raise a contact pre-draw signal here.  The callback will return
 an already
          * escaped version of name.
          */
         esc = purple_signal_emit_return_1(pidgin_blist_get_handle(),
 "drawing-buddy", b);
         if (!esc)
                 esc = g_markup_escape_text(name, strlen(name));

 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:53>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list