[Pidgin] #11262: list argument is not used in pidgin_blist_set_visible

[Pidgin]

#11262: list argument is not used in pidgin_blist_set_visible
----------------------+-----------------------------------------------------
 Reporter:  andrikos  |        Owner:              
     Type:  defect    |       Status:  new         
Milestone:            |    Component:  pidgin (gtk)
  Version:  2.6.5     |   Resolution:              
 Keywords:            |  
----------------------+-----------------------------------------------------
Description changed by andrikos:

Old description:

> In gtkblist.c: 6804 there is the PurpleBuddyList *list argument, but
> inside the function body the gtkblist variable is used.
>
> This was done maybe unintentionally, but it is still a bug. I see 3
> possible fixes:
> a) rename the list argument to gtkblist. this will mask and maybe
> conflict with the global (file scope) variable gtkblist used now
> b) remove the list argument since it is not needed (if the gtkblist use
> has been done intentionally) which is the most compatible-friendly option
> c) rename the use of gtkblist in the function body to the correct list
> variable (i guess this is the correct way to go, although I am not aware
> of possible new bugs from this change)

New description:

 In gtkblist.c: 6804 there is the PurpleBuddyList *list argument, but
 inside the function body the gtkblist variable is used.

 This was done maybe intentionally, but it is still a bug. I see 3 possible
 fixes:
 a) rename the list argument to gtkblist. this will mask and maybe conflict
 with the global (file scope) variable gtkblist used now
 b) remove the list argument since it is not needed (if the gtkblist use
 has been done intentionally) which is the most compatible-friendly option
 c) rename the use of gtkblist in the function body to the correct list
 variable (i guess this is the correct way to go, although I am not aware
 of possible new bugs from this change)

--

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11262#comment:1>
Pidgin <http://pidgin.im>
Pidgin