[Pidgin] #3329: Autocompletion of screennames with spaces
Pidgin
trac at pidgin.im
Thu Jan 28 17:28:40 EST 2010
#3329: Autocompletion of screennames with spaces
------------------------------------+---------------------------------------
Reporter: k1gwb | Owner:
Type: patch | Status: new
Milestone: Patches Needing Review | Component: pidgin (gtk)
Version: 2.2.0 | Resolution:
Keywords: tab autocomplete |
------------------------------------+---------------------------------------
Comment(by sadrul):
Replying to [ticket:10793 patch by mthurman]:
> This patch fixes the problem with tab completion as outlined in 3329 (a
defect). We essentially used the code that was already in the function and
just move things around. Being new, we didn't want to change too much but
we don't see the need for both temp and nick_partial (even though we kept
both).
>
> Since we can assume that entered has no white space, we solved the
problem by stripping out spaces from the name we are comparing to. I'm not
sure if '\t', '\r', '\n' (etc) are valid in names (I assume not) but they
would still not be matched with this code.
>
> This patch is submitted by Mark Thurman (mthurman AT gmail DOT com) and
Anthony Hugh (ahugh23 AT gmail DOT com).
The assumption that 'entered' has no white space may not always be
correct. For example, if we have two entries 'M Purple' and 'M Pidgin',
then there's no way of tab-completing either names with this patch. A
cleverer algorithm is needed for this.
--
Ticket URL: <http://developer.pidgin.im/ticket/3329#comment:9>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list