[Pidgin] #11635: QQ client version should be qq2008

Pidgin trac at pidgin.im
Tue Jul 6 11:10:08 EDT 2010


#11635: QQ client version should be qq2008
---------------------+------------------------------------------------------
 Reporter:  xhacker  |        Owner:  csyfek
     Type:  defect   |       Status:  new   
Milestone:           |    Component:  QQ    
  Version:           |   Resolution:        
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by mterry):

 Here's a patch that fixes the issue for me and lets me connect.  I
 reversed the order of the list given to purple_account_option_list_new [1]
 for "client_version" to set qq2008 as default and changed how it parses
 the field to use qq2008 if no value was given.

 I did *not* remove any of the support for qq2005 or qq2007, both of which
 are still in the code base.  I figured I would just screw something up if
 I did that.  But that would be good future work, to make the plugin
 simpler.

 [1] Would be nice if it didn't implicitly use the first item in the list
 as the default.  Either document such behavior in the API docs for the
 function or add a new field for the default value, like the other
 option_*_new functions.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11635#comment:4>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list