[Pidgin] #10833: Offline ICQ Messages Sent with Wrong Encoding

[Pidgin]

#10833: Offline ICQ Messages Sent with Wrong Encoding
--------------------+-------------------------------------------------------
 Reporter:  assen   |        Owner:  MarkDoliner
     Type:  defect  |       Status:  closed     
Milestone:          |    Component:  ICQ        
  Version:  2.6.3   |   Resolution:  fixed      
 Keywords:          |  
--------------------+-------------------------------------------------------
Changes (by ivan.komarov at soc.pidgin.im):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [d1c89d7bc669f5fa5636b54af6a36e6640d021e1]):[[BR]]
 Stop using custom encodings (and LATIN-1, for that matter) for sending
 OSCAR messages (ICBM, chat, Direct IM). Now, we use ASCII if a message
 contains ASCII characters only, and UTF-16 in all other cases.

 That fixes #10833 (offline messages now will be sent as UTF-16)
 and also a whole bunch of potential problems we can get
 with charset 0x3. Different clients tend to interpret this
 charset differently; for instance, the official client
 always interprets it as LATIN-1, while alternative
 clients may decode it as some other user-specified
 8-bit encoding. On the other hand, ASCII messages
 (charset 0x0) and UTF-16 messages (charset 0x2) are understood
 uniformly by all clients.

 I also cleaned-up the code a little (got rid of code paths that were
 never executed, flags that were always set, unused struct members, etc.)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10833#comment:2>
Pidgin <http://pidgin.im>
Pidgin