[Pidgin] #10633: ICQ Invisible mode set custom status text to "Invisible"

[Pidgin]

#10633: ICQ Invisible mode set custom status text to "Invisible"
-------------------------------------+--------------------------------------
 Reporter:  marq                     |        Owner:  MarkDoliner
     Type:  defect                   |       Status:  closed     
Milestone:                           |    Component:  ICQ        
  Version:  2.6.3                    |   Resolution:  fixed      
 Keywords:  invisible custom status  |  
-------------------------------------+--------------------------------------
Changes (by ivan.komarov at soc.pidgin.im):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [021e6a7b4ba46230e93812c39268259f8c6bc7fe]):[[BR]]
 "Invisibility mode" improvements.

   1. Removed the code for setting the status message to the status name
      (like "Available" or "Invisible") when no message is set by user.
      This should fix #10633, since now no one will see our status
      change to "Invisible" if we go invisible with no message set.
   2. Got rid of sending superfluous packets on server.
      * There's no need to call oscar_set_extended_status() from
        oscar_set_status_icq(), because in all cases it has already
        been called before that. The only thing oscar_set_status_icq()
        does except setting the extended status is setting the
        permit/deny setting, so I renamed it accordingly.
      * No need to call oscar_set_icq_permdeny() in
        purple_ssi_parseerr() (it will be called in purple_ssi_parselist()
 anyway).
      * Combined setting the extended status and the status message
        (as per TODO).
      This should fix the problem when client like QIP see us as Invisible
      for some (quite long) time before we appear as Offline.

 Also, I removed the code for setting the "itmsurl" status attribute,
 as there was no way to set this iTunes Store URL from the UI.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10633#comment:8>
Pidgin <http://pidgin.im>
Pidgin