[Pidgin] #11484: build of oscar.c fails

[Pidgin]

#11484: build of oscar.c fails
---------------------+------------------------------------------------------
 Reporter:  dimstar  |     Owner:  MarkDoliner
     Type:  patch    |    Status:  new        
Component:  ICQ      |   Version:  2.6.6      
 Keywords:           |  
---------------------+------------------------------------------------------
 in openSUSE we have some brp checks validating compiler output and
 complaining on known 'side effects'.

 for current pidgin, I see the following errors:

 E: pidgin 64bit-portability-issue oscar.c:3704

 The error is raised out of this warning:
 /bin/sh ../../../libtool --silent  --tag=CC   --mode=compile gcc
 -DHAVE_CONFIG_H -I. -I../../..  -I../../../libpurple -I../../../libpurple
 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -Wall
 -DPURPLE_DISABLE_DEPRECATED -DPIDGIN_DISABLE_DEPRECATED
 -DFINCH_DISABLE_DEPRECATED -DGNT_DISABLE_DEPRECATED -Waggregate-return
 -Wcast-align -Wdeclaration-after-statement -Wendif-labels -Werror-
 implicit-function-declaration -Wextra -Wno-sign-compare -Wno-unused-
 parameter -Wformat-security -Winit-self -Wmissing-declarations -Wmissing-
 noreturn -Wmissing-prototypes -Wpointer-arith -Wundef
 -Wp,-D_FORTIFY_SOURCE=2   -g -fmessage-length=0 -O2  -D_FORTIFY_SOURCE=2
 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -fstack-
 protector -fPIC -MT liboscar_la-oscar.lo -MD -MP -MF .deps/liboscar_la-
 oscar.Tpo -c -o liboscar_la-oscar.lo `test -f 'oscar.c' || echo
 './'`oscar.c
 oscar.c: In function 'purple_conv_chat_incoming_msg':
 oscar.c:3704:2: warning: passing argument 1 of 'time' makes pointer from
 integer without a cast
 /usr/include/time.h:186:15: note: expected 'time_t *' but argument is of
 type 'long int'

 The attached patch takes care of this and changes from time_t to time_t*
 (as the prototype suggests).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11484>
Pidgin <http://pidgin.im>
Pidgin