[Pidgin] #11431: Signals no longer work in Perl plugins

[Pidgin]

#11431: Signals no longer work in Perl plugins
----------------------+-----------------------------------------------------
 Reporter:  dharding  |        Owner:  MarkDoliner
     Type:  defect    |       Status:  new        
Milestone:  2.7.0     |    Component:  plugins    
  Version:  2.6.6     |   Resolution:             
 Keywords:  perl      |  
----------------------+-----------------------------------------------------

Comment(by dharding):

 Replying to [comment:10 MarkDoliner]:
 > The original code behaved correctly, right?  It just had a spurious
 warning?

 As best as I can tell, yes.  I don't have a x86-64 system that I can test
 Pidgin on, but running a simple test program on x86-64 seems to indicate
 that the original code worked correctly on both x86 and x86-64, even
 though it generated a warning when compiled on the latter platform.

 > But I'm leaning toward just adding a cast for that specific case.  How
 do you feel about the attached patch coupled with
 http://developer.pidgin.im/viewmtn/revision/info/67de3fff150c538c01ca66706c29a8f19cbfeff1?

 As far as I can tell that should work - my testing indicates that it
 should give the correct behavior on both platforms without any warnings.
 It has been awhile since I delved into the complexities of C array/pointer
 conversions, so I haven't figured out how on platforms where va_list is an
 array, a va_list can be passed to another function as either a va_list or
 a va_list* and still behave correctly - but it seems that it does in fact
 behave correctly, so adding a cast seems the smallest fix to deal with the
 warning.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11431#comment:11>
Pidgin <http://pidgin.im>
Pidgin