[Pidgin] #11478: Yahoo Crash when transparently proxied

[Pidgin]

#11478: Yahoo Crash when transparently proxied
--------------------------------------+-------------------------------------
 Reporter:  myrlyn                    |        Owner:  sulabh.dev         
     Type:  defect                    |       Status:  closed             
Milestone:  2.7.0                     |    Component:  Yahoo!/Yahoo! JAPAN
  Version:  2.6.6                     |   Resolution:  fixed              
 Keywords:  yahoo proxy crash msvcrt  |  
--------------------------------------+-------------------------------------

Comment(by rekkanoryo at pidgin.im):

 (In [6a525a20cfffe39369fb58b72aeaf5194aa468d9]):[[BR]]
 Pluck yahoo-related revisions; authorized by Zac West.

 *** Plucked rev f1264b136d57d1ee917f59945e91b9b2bd4b2410
 (rekkanoryo at pidgin.im):
 Attempt to handle transparent proxies that return documents instead of
 errors.
 I think this fixes #11478.

 *** Plucked rev 17c1e048674ec57bdadbafc0b1e598a37143eccd
 (rekkanoryo at pidgin.im):
 Document the code I just touched, and use a convenience variable in a
 couple
 more places to make the code easier to read.

 *** Plucked rev a87af6413b6aef7fd11608c15fb50aee2ac3d21e
 (vamposdecampos at gmail.com):
 yahoo: fix decoding of P2P session_id

 Apparently, inbound P2P packets containing key-11 session_id are
 no longer sent by the server with a YAHOO_STATUS_BRB, but rather
 a status value of 11.

 Since we don't pick up the session_id, the first text message we
 send over the P2P connection will have a key-11 value of 0, and cause
 the remote (yahoo) client to disconnect us.  This is causing the
 "lost second line in a conversation" syndrome.

 Fix it by also accepting status 11 in yahoo_process_p2p().

 Fixes #10733.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11478#comment:9>
Pidgin <http://pidgin.im>
Pidgin