[Pidgin] #11546: Jabber w/ CYRUS-SASL and no saved password fails to prompt at connect time

[Pidgin]

#11546: Jabber w/ CYRUS-SASL and no saved password fails to prompt at connect time
--------------------+-------------------------------------------------------
 Reporter:  evands  |        Owner:  deryni 
     Type:  defect  |       Status:  pending
Milestone:          |    Component:  XMPP   
  Version:  2.6.6   |   Resolution:         
 Keywords:          |  
--------------------+-------------------------------------------------------
Changes (by darkrain42):

  * status:  new => pending


Comment:

 I believe the log issue ("Invalid challenge from server") is a result of
 Adium's patch to use the built-in DIGEST-MD5 implementation instead of
 Cyrus's.  If DIGEST-MD5 fails,  Adium does not then fallback to trying
 other mechanisms with Cyrus  (There's another Adium ticket open for this,
 except with GSSAPI, which I can't find).

 However, libpurple should be prompting for a password ''before'' getting
 this far; in fact, it should prompt for a password before getting to that
 point, as DIGEST-MD5 requires a password (the first if statement under the
 SASL_NOMECH case should be triggered).

 {{{
         switch (js->sasl_state) {
             /* Success */
             case SASL_OK:
             case SASL_CONTINUE:
                 break;
             case SASL_NOMECH:
                 /* No mechanisms have offered to help */

                 /* Firstly, if we don't have a password try
                  * to get one
                  */

                 if (!purple_account_get_password(js->gc->account)) {
                     purple_account_request_password(js->gc->account,
 G_CALLBACK(auth_pass_cb), G_CALLBACK(auth_no_pass_cb), js->gc);
                     return;
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11546#comment:2>
Pidgin <http://pidgin.im>
Pidgin