[Pidgin] #11471: Decoding problem in cyrillic auth requests in ICQ

Pidgin trac at pidgin.im
Fri Mar 19 11:23:15 EDT 2010


#11471: Decoding problem in cyrillic auth requests in ICQ
------------------------------------+---------------------------------------
 Reporter:  ari                     |        Owner:  MarkDoliner
     Type:  patch                   |       Status:  closed     
Milestone:  Patches Needing Review  |    Component:  ICQ        
  Version:  2.6.6                   |   Resolution:  fixed      
 Keywords:                          |  
------------------------------------+---------------------------------------
Changes (by MarkDoliner):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 I think I might have fixed this in
 r4f0c3aedc3b013ab2175e57b71bab92988e4f812, for ticket #7457.  If anyone
 wants to test it, feel free.  If it doesn't work for you please let me
 know what client was used to SEND the authorization request, because it's
 possibly they're using the wrong encoding.

 The patch you linked to looks like it does reasonable things... but the
 functions it changes are already pretty complicated.  It's already very
 difficult to tell what kind of an impact that change would have on other
 places in the oscar prpl.  Ideally very few places in oscar would call
 those functions, since they involve guessing at the encoding of the
 string.  We should isolate those places and be very certain that there is
 no way to know the encoding of the string.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11471#comment:10>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list