[Pidgin] #11320: Pidgin incorrectly requests plaintext auth over an unencrypted connection for XMPP if an unknown mechanism is seen by cyrus-sasl

[Pidgin]

#11320: Pidgin incorrectly requests plaintext auth over an unencrypted connection
for XMPP if an unknown mechanism is seen by cyrus-sasl
-------------------------+--------------------------------------------------
 Reporter:  dreiss       |        Owner:  deryni
     Type:  enhancement  |       Status:  new   
Milestone:               |    Component:  XMPP  
  Version:  2.6.4        |   Resolution:        
 Keywords:               |  
-------------------------+--------------------------------------------------

Comment(by dreiss):

 Sorry this took so long.  While investigating further, I found that the
 code already special-cases Google's site-specific login mechanism, so I
 just added Facebook's to that code.  This resolves the issue that I'm
 primarily concerned with, which is that the warning pops up when you try
 to log into Facebook Chat with incorrect credentials.

 In general, though, I think I did find a way to query the correct data
 from Cyrus SASL, if you are interested.  It seems like sasl_listmech
 actually gives the list of mechanisms that the client is able to use.  I
 was confused by the documentation at first because it is written from the
 perspective of the server.  It should be possible to build two sasl
 objects, one with plaintext auth allowed and one without, use
 sasl_listmech to get the list of supported mechanisms from each, take the
 set difference, and check to see if any of those are offered by the
 server.  I didn't write up a patch for this because the code is probably
 quite cumbersome and it seems like overkill.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11320#comment:6>
Pidgin <http://pidgin.im>
Pidgin