[Pidgin] #11595: libpurple - MSN crashes when sending file
Pidgin
trac at pidgin.im
Sat Mar 27 16:55:33 EDT 2010
#11595: libpurple - MSN crashes when sending file
--------------------+-------------------------------------------------------
Reporter: hanzz | Owner: QuLogic
Type: defect | Status: new
Milestone: | Component: MSN
Version: 2.6.6 | Resolution:
Keywords: |
--------------------+-------------------------------------------------------
Comment(by hanzz):
Ok, I can't test it just now on our production server, but I think this
patch will fix my problem:
{{{
--- slplink.c 2010-03-27 21:54:26.000000000 +0100
+++ slplink1.c 2010-03-27 21:54:50.000000000 +0100
@@ -311,6 +311,7 @@ msg_ack(MsnMessage *msg, void *data)
{
if (slpmsg->slpcall->xfer &&
purple_xfer_get_status(slpmsg->slpcall->xfer) ==
PURPLE_XFER_STATUS_STARTED)
{
+ msn_message_ref(msg);
slpmsg->slpcall->xfer_msg = slpmsg;
purple_xfer_prpl_ready(slpmsg->slpcall->xfer);
}
}}}
This leask, because you have to unref that message somewhere, but I really
don't know what's the life-cycle of that message should be... Use it as
inspiration.
--
Ticket URL: <http://developer.pidgin.im/ticket/11595#comment:3>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list