[Pidgin] #11863: Using "Get X-Status Msg" on offline ICQ buddy causes Pidgin's crash

[Pidgin]

#11863: Using "Get X-Status Msg" on offline ICQ buddy causes Pidgin's crash
--------------------------------------+-------------------------------------
 Reporter:  Fellrond                  |        Owner:  MarkDoliner
     Type:  defect                    |       Status:  new        
Milestone:  2.7.1                     |    Component:  ICQ        
  Version:  2.7.0                     |   Resolution:             
 Keywords:  x-status oscar icq 2.7.0  |  
--------------------------------------+-------------------------------------

Comment(by darkrain42):

 Also https://bugzilla.redhat.com/show_bug.cgi?id=592258 &
 https://bugzilla.redhat.com/show_bug.cgi?id=592194.

 The issue is that 8c322571bfb4f2d00c9126e59746445f877be296 updated
 purple_parse_msgerr, but only updated one of the two possible call sites
 (the other one being misc.c:generror().

 {{{
 <&nosnilmot> ah ha. and my attempt to reproduce did log this:
  (10:03:07) oscar: icbm error: received response from request without a
 buddy name!
  so error() is returning 0 and it's falling back to generror() ?
 < darkrain42> Yeah, I think so.
 < darkrain42> I guess generror() could be taught to add the extra argument
 if it's
                        an ICBM SNAC (these names make me feel silly), if
 there's no better
                        solution
 <&nosnilmot> there's also the question of why the response has no buddy
 name
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11863#comment:4>
Pidgin <http://pidgin.im>
Pidgin