[Pidgin] #11863: Using "Get X-Status Msg" on offline ICQ buddy causes Pidgin's crash

Pidgin trac at pidgin.im
Wed May 19 21:44:12 EDT 2010


#11863: Using "Get X-Status Msg" on offline ICQ buddy causes Pidgin's crash
--------------------------------------+-------------------------------------
 Reporter:  Fellrond                  |        Owner:  MarkDoliner
     Type:  defect                    |       Status:  closed     
Milestone:  2.7.1                     |    Component:  ICQ        
  Version:  2.7.0                     |   Resolution:  fixed      
 Keywords:  x-status oscar icq 2.7.0  |  
--------------------------------------+-------------------------------------
Changes (by markdoliner at pidgin.im):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [e3dd36706068f3b8eabd630ff71d270c145cce42]):[[BR]]
 If we get an error SNAC on the ICBM family and it's missing buddy name
 then
 don't fallthrough to the default error handler in misc.c.  This was
 causing
 purple_parse_msgerr() in oscar.c to get called with different va_args than
 it was expecting, which caused a crash.  Specifically when trying to fetch
 the ICQ x-status of an offline buddy.

 Fixes #11863.  This is nosnilmot's patch, I believe.  I had no part in it,
 other than verifying that I do believe it'll fix the crash.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11863#comment:20>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list