[Pidgin] #10540: disable 'unread messages' popup for single conversation?

Pidgin trac at pidgin.im
Fri May 28 10:44:58 EDT 2010


#10540: disable 'unread messages' popup for single conversation?
-------------------------------------------------+--------------------------
 Reporter:  paarseduif                           |        Owner:  rekkanoryo  
     Type:  defect                               |       Status:  new         
Milestone:                                       |    Component:  unclassified
  Version:  2.6.1                                |   Resolution:              
 Keywords:  unseen unread messages are you sure  |  
-------------------------------------------------+--------------------------

Comment(by paarseduif):

 The "You have unread messages" is in gtkconv.c, in the function
 {{{  build_warn_close_dialog(PidginWindow *gtkwin) }}}
 which is referenced by:
 {{{  close_win_cb(GtkWidget *w, GdkEventAny *e, gpointer d)}}}

 The code responsible is:
 {{{
     /* If there are unread messages then show a warning dialog */
     for (l = pidgin_conv_window_get_gtkconvs(win);
          l != NULL; l = l->next)
     {
         PidginConversation *gtkconv = l->data;
         if (purple_conversation_get_type(gtkconv->active_conv) ==
 PURPLE_CONV_TYPE_IM &&
                 gtkconv->unseen_state >= PIDGIN_UNSEEN_TEXT)
         {
             build_warn_close_dialog(win);
             gtk_widget_show_all(warn_close_dialog);

             return TRUE;
         }
     }
 }}}

 I think commenting out those two lines this way:
 {{{
 //            build_warn_close_dialog(win);
 //            gtk_widget_show_all(warn_close_dialog);
 }}}
 should work for samineru, but I rather see someone add some code to check
 if it's just 1 unread conversation by checking the length of the
 list/array pidgin_conv_window_get_gtkconvs(win); (don't know if this is
 the right way)
 And, if it's just one unread conversation, skip building/showing the
 dialog window.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10540#comment:3>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list