[Pidgin] #12617: Patch to add out-of-band DTMF support

Pidgin trac at pidgin.im
Sat Nov 6 16:50:41 EDT 2010


#12617: Patch to add out-of-band DTMF support
-----------------------------------------+----------------------------------
 Reporter:  BigBrownChunx                |        Owner:  darkrain42
     Type:  patch                        |       Status:  new       
Milestone:  Patches Needing Improvement  |    Component:  libpurple 
  Version:  2.7.3                        |   Resolution:            
 Keywords:  dtmf media                   |  
-----------------------------------------+----------------------------------
Changes (by darkrain42):

  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 BigBrownChunx: Shouldn't purple_media_send_dtmf validate the character is
 a specific DTMF tone?

 Please also document in the .h that they're sent in a protocol-specific
 way if the protocol has it, or as in-band if the media backend supports
 it.  I'm also not sure that if the prpl returns FALSE, we should really
 fall back to in-band (I'm open to being convinced)

 The newer Farsight code looks nice :)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12617#comment:13>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list