[Pidgin] #12856: MSN support becomes corrupt on NetBSD and #pragma pack(push, n)

[Pidgin]

#12856: MSN support becomes corrupt on NetBSD and #pragma pack(push, n)
----------------------------+-----------------------------------------------
 Reporter:  KawatoriShinji  |     Owner:  QuLogic
     Type:  patch           |    Status:  new    
Component:  MSN             |   Version:  2.7.5  
 Keywords:                  |  
----------------------------+-----------------------------------------------
 Running finch 2.7.3 on NetBSD, MSN support becomes corrupt after a while,
 buddy statuses become inaccurate, and logging fails. Disabling/enabling
 the account does not fix this, but a restart of finch does. 2.6.x did not
 have this issue.

 When recently updating to 2.7.5, I noticed that there were warnings in the
 MSN code about {{{#pragma pack(push, n)}}} and {{{#pragma pack(pop)}}} not
 being supported on the target (x86_64--netbsd). I patched these instances
 to use {{{__attribute__ ((__packed__))}}} if {{{__GNUC__}}} is defined and
 to use the pragma if {{{_WIN32}}} is defined.

 I do not know something between 2.7.3 fixed the problem or if this patch
 fixed it, but MSN works fine now; I have been running finch for 5 days
 with no issue. I haven't had a chance to test my patch on 2.7.3 yet to see
 if packing was the issue, since I actively use my MSN account.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12856>
Pidgin <http://pidgin.im>
Pidgin