[Pidgin] #10891: gevolution plugin adds buddies to random account

[Pidgin]

#10891: gevolution plugin adds buddies to random account
-----------------------------------------+----------------------------------
 Reporter:  cedel                        |        Owner:         
     Type:  patch                        |       Status:  new    
Milestone:  Patches Needing Improvement  |    Component:  plugins
  Version:  2.6.3                        |   Resolution:         
 Keywords:                               |  
-----------------------------------------+----------------------------------

Comment(by cedel):

 Replying to [comment:11 QuLogic]:
 > What is `changewin->selection` for? It does not appear to be used
 outside of the function in which it is set, so why does it need to be
 saved?

 Please, can you be more specific, on what line number? Cause if I look at
 the last published version of the patch, I don't see it anywhere? But I am
 sleepy now...

 > Using `g_list_length` to check if the list is 0, 1, or "many" is not
 necessary. Just check `list` and `list->next`. Also, you call
 `g_list_length` multiple times instead of using the cached value in `d`.

 True, but it seems more understandable this way (at least for me) and
 debug gets fresh info if something happened (so g_list_length gets called
 twice within the same function). But will check on this one again later.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10891#comment:13>
Pidgin <http://pidgin.im>
Pidgin