[Pidgin] #12653: jabber_add_feature may lead to disco#info and caps hash mismatching

[Pidgin]

#12653: jabber_add_feature may lead to disco#info and caps hash mismatching
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |     Owner:  darkrain42
     Type:  defect      |    Status:  new       
Component:  XMPP        |   Version:  2.7.3     
 Keywords:              |  
------------------------+---------------------------------------------------
 Per #a14273, the `jabber_disco_info_parse` response may end up responding
 to an out-of-date caps hash with a new set of features if something
 (Adium) adds a new one or a new one is enabled (Jingle, buzz) since the
 caps hash was generated.  I've also observed this previously in Pidgin,
 though the exact reproduction method there escapes me

 This needs to be fixed.

 Possible solutions:
    * Track and respond to previously advertised hashes (but only those
 that have been advertised by this account so we don't end up being an
 oracle -- not that I see an attack vector for this ATM)
    * Having jabber_add_feature either rebroadcast new presences or expire
 current hashes

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12653>
Pidgin <http://pidgin.im>
Pidgin