[Pidgin] #13370: libpurple jabber does not process avatar removal updates

[Pidgin]

#13370: libpurple jabber does not process avatar removal updates
-----------------------------------------+----------------------------------
 Reporter:  mentor                       |        Owner:  deryni
     Type:  defect                       |       Status:  new   
Milestone:  Patches Needing Improvement  |    Component:  XMPP  
  Version:  2.7.10                       |   Resolution:        
 Keywords:                               |  
-----------------------------------------+----------------------------------
Changes (by darkrain42):

  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 A few observations (mostly from deryni):
    * The logic in the first chunk is still wrong (see my previous note)
    * {{{ const char *ah = presence->vcard_avatar_hash != "" ? }}} <-- not
 equals "" is very likely wrong
    * Can't the XOR be replaced with a purple_strequal(string1, string2)?
 (all you're looking for is whether the strings are equal or not, right?)
    * ?: is a GNUism.

 Also, your indentation is off (there are extraneous indentation changes).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13370#comment:10>
Pidgin <http://pidgin.im>
Pidgin