[Pidgin] #13859: [PATCH] another update for NetworkManager 0.9

Pidgin trac at pidgin.im
Tue Apr 26 13:39:48 EDT 2011


#13859: [PATCH] another update for NetworkManager 0.9
------------------------------------+---------------------------------------
 Reporter:  dcbw                    |        Owner:           
     Type:  patch                   |       Status:  new      
Milestone:  Patches Needing Review  |    Component:  libpurple
  Version:  2.7.11                  |   Resolution:           
 Keywords:                          |  
------------------------------------+---------------------------------------
Changes (by Robby):

  * type:  enhancement => patch
  * milestone:  => Patches Needing Review


Old description:

> This patch builds on the previous patch (issue 13505); there have been
> some cleanups since then.  I missed updating the StateChanged signal;
> "StateChange" has been deprecated since NM 0.9 (2008), and the new name
> "StateChanged" has existed since the deprecation (2008), so it should be
> fine to simply change the signal name.  Second there's one other place
> that I forgot to update the state names; this will have an effect in the
> future, but not at the moment since NM headers define NM_STATE_CONNECTED
> = NM_STATE_CONNECTED_GLOBAL right now for backwards compat, plus the
> other states are not yet used (but will be soon).

New description:

 This patch builds on the previous patch (#13505); there have been some
 cleanups since then.  I missed updating the StateChanged signal;
 "StateChange" has been deprecated since NM 0.9 (2008), and the new name
 "StateChanged" has existed since the deprecation (2008), so it should be
 fine to simply change the signal name.  Second there's one other place
 that I forgot to update the state names; this will have an effect in the
 future, but not at the moment since NM headers define NM_STATE_CONNECTED =
 NM_STATE_CONNECTED_GLOBAL right now for backwards compat, plus the other
 states are not yet used (but will be soon).

--

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13859#comment:2>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list